search

fishi0x01 / vsh

vsh - HashiCorp Vault interactive shell and cli tool
MIT License
284 stars 12 forks source link

Add replace command #60

Closed fishi0x01 closed 3 years ago

fishi0x01 commented 3 years ago

Fixes #59

mattlqx commented 3 years ago

@fishi0x01 would you like me to take a stab at replace or do you want to continue on with this one? I think we could leverage some of grep's implementation for it at this point.

fishi0x01 commented 3 years ago

@mattlqx Feel free to take this one over. Thanks a bunch again :bow:

I will in the meanwhile work on this issue: https://github.com/fishi0x01/vsh/issues/67

fishi0x01 commented 3 years ago

@mattlqx Id like to merge this PR now. It prevents fiddling with the metadata in KV2. However, it might affect your current work - so I could also wait with merging if you want.

mattlqx commented 3 years ago

Thanks for the consideration! That pull is a good improvement. Please go ahead and merge it.

fishi0x01 commented 3 years ago

Implemented by #69