search

fishin / discuss

discussion repo
2 stars 0 forks source link

Help #1

Open simon-p-r opened 9 years ago

simon-p-r commented 9 years ago

Hello

If I can help with this project at all I will! I like using hapi ecosystem and believe a CI would be great for node.

Thanks Simon

lloydbenson commented 9 years ago

That'd be helpful! The top level project is ficion. Take a look at that README and let me know if it makes sense or needs more work. Currently its somewhat hapi specific but it works in generic ways. If its helpful I could start a gitter room or something if you want to collaborate / discuss ideas!

simon-p-r commented 9 years ago

Yes :+1: I will do some reading and join a gitter room for discussions, I am relatively new to developing but eager to learn through experience.

lloydbenson commented 9 years ago

I look forward to collaborating! I make a gitter room and added it to the README for both ficion repo and discuss.

simon-p-r commented 9 years ago

Ok I have got ficion working partially on my Windows box via git bash environment however I have made some comments based on instructions at ficion repo.

I am willing to help in whatever way as it is a cool project!

lloydbenson commented 9 years ago

Thanks for the feedback. When doing this project I reduced scope a bit so I would actually accomplish something and I don't have a windows environment available. So with that said:

  1. The shell scripts have some logic in them I didn't think was easy to do otherwise. It generates an environment specific config, and backgrounds both the UI and the API processes. Any suggestions on how to make this more generic to support windows?
  2. Permissions for github token. Updated the README. Is this sufficient now or do you think more is required?
  3. Interesting, I guess I wrongly assume you are familiar with how hapi plugins work (essentially all the options). I think this is likely related to a setup script. I had in the README to set something up. Maybe a yeoman generator? Thoughts on improvement?
  4. There is a bug against good-file for this with a help wanted tag: https://github.com/hapijs/good-file/issues/55 It does complain but doesn't prevent app startup.
  5. See 3, but what do you think should be done, a yeoman generator? I haven't used one, but if you have maybe you could offer some advice (or any other solution (cant use bash as you don't want it to not be supportable on windows)
  6. Those are just paths to store the data. It's possible people want to separate out the directory structures in different ways. It will auto create these but you still need to define these. As part of the generator we could just make these relative?
  7. Yes, a user guide is a great idea, thoughts on some structure on an outline?

Followup, when you said you got it partially working, what are the specifics of what you didn't get going?

Thanks for all the great feedback and look forward to hearing about your ideas to make this more cross platform friendly.

lloydbenson commented 9 years ago

For 1 I changed npm start to start up lib/start.js. It's just a start. It won't background your process but it will start it up without hte bash script and run the confidence stuff it needs to. To stop it you can just hit control c. Let me know if thats sufficient.

For old behavior I setup npm run bash-start and run run bash-stop for myself ;)

Let me now if that is more windows friendly.

lloydbenson commented 9 years ago

For 6. I added a couple of items in the README that should help. Let me know if that clarifies it better until a more complete installer can be done.

simon-p-r commented 9 years ago

:tada: for new npm start, works a charm!

lloydbenson commented 9 years ago

Great. Let me know once you get some directories for tacklebox created and your tacklebox_confidence.json updated to those directories if that works better. I'll try to find out what folks are doing for config generation (I personally like to just edit config files but I realize some folks prefer more help there).

simon-p-r commented 9 years ago

I have used generators before which would be a quick way to generate files based on some user answered questions, it could create config files and create folders structures without much effort.

lloydbenson commented 9 years ago

Is "yo" a good use case here? If so I can quickly research how to use it and do a npm run generate-config or something that calls that.

simon-p-r commented 9 years ago

Yes yo is easy to create a generator with

lloydbenson commented 9 years ago

create I'll read up on that and see how it goes.

lloydbenson commented 9 years ago

Cool, took a quick look, lots of libraries that are required for that. I may just try to make one up using process first so I don't have to import so many lib dependencies.

lloydbenson commented 9 years ago

FYI i changed npm stop and start back to the original but you can use npm run start-simple for the non-bash way. I have updated the README appropriately.