Closed mickel8 closed 11 months ago
Merging #101 (8f3b9b5) into main (9625b3a) will increase coverage by
0.08%
. Report is 1 commits behind head on main. The diff coverage is85.71%
.:exclamation: Current head 8f3b9b5 differs from pull request most recent head 3e96eaf. Consider uploading reports for the commit 3e96eaf to get more accurate results
@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 83.48% 83.56% +0.08%
==========================================
Files 44 44
Lines 769 779 +10
==========================================
+ Hits 642 651 +9
- Misses 127 128 +1
Files | Coverage Δ | |
---|---|---|
lib/jellyfish/application.ex | 47.82% <100.00%> (+10.98%) |
:arrow_up: |
lib/jellyfish/config_reader.ex | 100.00% <100.00%> (ø) |
|
lib/jellyfish/peer/webrtc.ex | 48.27% <50.00%> (ø) |
|
lib/jellyfish/room.ex | 81.88% <87.50%> (+0.14%) |
:arrow_up: |
lib/jellyfish_web/telemetry.ex | 88.88% <50.00%> (-11.12%) |
:arrow_down: |
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 86258b4...3e96eaf. Read the comment docs.
We can't use
jellyfish
as default node name when we also use longnames as default distribution mode. Therefore it is better to just raise. That's also symmetric with the behavior when running from source