fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 12 forks source link

Add vod hls #110

Closed Karolk99 closed 10 months ago

Karolk99 commented 10 months ago

Acknowledging the stipulations set forth:

Before implementing SDK and documentation PRs I want your feedback on these changes

codecov[bot] commented 10 months ago

Codecov Report

Merging #110 (ef9de78) into main (2634296) will increase coverage by 1.99%. The diff coverage is 93.22%.

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   84.29%   86.28%   +1.99%     
==========================================
  Files          47       50       +3     
  Lines         853      897      +44     
==========================================
+ Hits          719      774      +55     
+ Misses        134      123      -11     
Files Coverage Δ
lib/jellyfish/application.ex 50.00% <100.00%> (+2.17%) :arrow_up:
lib/jellyfish/component/hls.ex 94.11% <100.00%> (ø)
lib/jellyfish/component/hls/ets_helper.ex 100.00% <100.00%> (ø)
lib/jellyfish/component/hls/request_handler.ex 91.30% <100.00%> (+0.39%) :arrow_up:
lib/jellyfish_web/api_spec/responses.ex 100.00% <ø> (ø)
lib/jellyfish_web/controllers/hls_controller.ex 90.00% <ø> (ø)
lib/jellyfish_web/controllers/recording_json.ex 100.00% <100.00%> (ø)
lib/jellyfish_web/router.ex 100.00% <100.00%> (ø)
lib/jellyfish/component/hls/recording.ex 91.66% <91.66%> (ø)
lib/jellyfish/room.ex 85.21% <93.75%> (+0.53%) :arrow_up:
... and 1 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2634296...ef9de78. Read the comment docs.