Closed Rados13 closed 10 months ago
I am not sure but we could make room_conn
and conn
distinction on purpose. @Karolk99 do you remember why?
I am not sure but we could make
room_conn
andconn
distinction on purpose. @Karolk99 do you remember why?
I'm not sure. I think I made those tests analogical to the setup implementation. Sometimes there is a problem with reusing the connection (Plug.Conn.AlreadySentError). @Rados13 why didn't you change room_conn
in setup?
I am not sure but we could make
room_conn
andconn
distinction on purpose. @Karolk99 do you remember why?I'm not sure. I think I made those tests analogical to the setup implementation. Sometimes there is a problem with reusing the connection (Plug.Conn.AlreadySentError). @Rados13 why didn't you change
room_conn
in setup?
I didn't change it because of the error you mentioned. If I understand this Phoenix mechanism correctly, we should use the output connection from the previous request as input in the next request. But because on_exit
is called after tests, we can't use it that way. But I am not sure about it.
Merging #114 (653ea54) into main (7e03dcb) will not change coverage. Report is 3 commits behind head on main. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #114 +/- ##
=======================================
Coverage 86.33% 86.33%
=======================================
Files 50 50
Lines 922 922
=======================================
Hits 796 796
Misses 126 126
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7e03dcb...653ea54. Read the comment docs.
Acknowledging the stipulations set forth:
This PR fixes two tests:
list all rooms
test by disallowing parallel tests for this module and deleting all rooms before running any test case in this module. Previously, there was a possibility that there was another room in jellyfish before starting this test case.In addition, in
component_controller_test.exs
, the naming for connection was unified, so in all test cases, we use the nameconn
instead of mixingconn
androom_conn