fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 10 forks source link

Add subsrcibe mode to hls component #118

Closed Karolk99 closed 9 months ago

Karolk99 commented 9 months ago

Acknowledging the stipulations set forth:

codecov[bot] commented 9 months ago

Codecov Report

Merging #118 (05e8ae1) into main (67620f4) will increase coverage by 0.20%. Report is 1 commits behind head on main. The diff coverage is 95.45%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #118 +/- ## ========================================== + Coverage 86.09% 86.30% +0.20% ========================================== Files 52 54 +2 Lines 971 993 +22 ========================================== + Hits 836 857 +21 - Misses 135 136 +1 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/component/hls.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvaGxzLmV4) | `91.30% <100.00%> (+0.39%)` | :arrow_up: | | [lib/jellyfish/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tLmV4) | `85.53% <100.00%> (+0.86%)` | :arrow_up: | | [lib/jellyfish\_web/api\_spec/component/hls.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvY29tcG9uZW50L2hscy5leA==) | `100.00% <ø> (ø)` | | | [lib/jellyfish\_web/api\_spec/subscription.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvc3Vic2NyaXB0aW9uLmV4) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish\_web/router.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvcm91dGVyLmV4) | `100.00% <100.00%> (ø)` | | | [...llyfish\_web/controllers/subscription\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvc3Vic2NyaXB0aW9uX2NvbnRyb2xsZXIuZXg=) | `88.88% <88.88%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/118?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/118?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [67620f4...05e8ae1](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/118?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).