fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 10 forks source link

Rtc 398 file endpoint #120

Closed roznawsk closed 9 months ago

roznawsk commented 9 months ago

Acknowledging the stipulations set forth:

  • [ ] I hereby confirm that a Pull Request involving updates to the Software Development Kit (SDK) has been smoothly merged, currently awaits processing, or is otherwise deemed unnecessary in this context. The changes to the SDKs will follow after implementing the File Endpoint
  • [x] I also affirm that another Pull Request, specifically addressing updates to the documentation body (commonly referred to as 'docs'), has either been successfully incorporated, is in the process of review, or is considered superfluous under the prevailing circumstances.
codecov[bot] commented 9 months ago

Codecov Report

Merging #120 (1bda09f) into main (67620f4) will decrease coverage by 0.37%. The diff coverage is 66.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #120 +/- ## ========================================== - Coverage 86.09% 85.72% -0.37% ========================================== Files 52 53 +1 Lines 971 974 +3 ========================================== - Hits 836 835 -1 - Misses 135 139 +4 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/component.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQuZXg=) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/component/hls.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvaGxzLmV4) | `90.90% <100.00%> (ø)` | | | [lib/jellyfish/component/rtsp.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvcnRzcC5leA==) | `100.00% <ø> (ø)` | | | [lib/jellyfish\_web/api\_spec/component/hls.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvY29tcG9uZW50L2hscy5leA==) | `100.00% <ø> (ø)` | | | [lib/jellyfish\_web/api\_spec/component/rtsp.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvY29tcG9uZW50L3J0c3AuZXg=) | `100.00% <ø> (ø)` | | | [lib/jellyfish\_web/controllers/component\_json.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvY29tcG9uZW50X2pzb24uZXg=) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tLmV4) | `84.00% <80.00%> (-0.67%)` | :arrow_down: | | [lib/jellyfish\_web/api\_spec/component/file.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvY29tcG9uZW50L2ZpbGUuZXg=) | `0.00% <0.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/120?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/120?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [67620f4...1bda09f](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/120?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).