fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 10 forks source link

[RTC-398] File component #123

Closed roznawsk closed 8 months ago

roznawsk commented 9 months ago

Ref: https://github.com/jellyfish-dev/membrane_rtc_engine/pull/333 (need merging for tests to pass)

Acknowledging the stipulations set forth:

codecov[bot] commented 9 months ago

Codecov Report

Merging #123 (d55d844) into main (10ef42c) will increase coverage by 0.26%. The diff coverage is 86.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #123 +/- ## ========================================== + Coverage 86.43% 86.70% +0.26% ========================================== Files 55 57 +2 Lines 1010 1038 +28 ========================================== + Hits 873 900 +27 - Misses 137 138 +1 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/component.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQuZXg=) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/component/file.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvZmlsZS5leA==) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/component/hls.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvaGxzLmV4) | `91.30% <100.00%> (ø)` | | | [lib/jellyfish/component/hls/recording.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvaGxzL3JlY29yZGluZy5leA==) | `89.47% <ø> (ø)` | | | [lib/jellyfish\_web/api\_spec/component.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvY29tcG9uZW50LmV4) | `100.00% <ø> (ø)` | | | [lib/jellyfish\_web/controllers/component\_json.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvY29tcG9uZW50X2pzb24uZXg=) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish\_web/api\_spec/component/file.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvY29tcG9uZW50L2ZpbGUuZXg=) | `66.66% <66.66%> (ø)` | | | [.../jellyfish\_web/controllers/component\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvY29tcG9uZW50X2NvbnRyb2xsZXIuZXg=) | `85.71% <0.00%> (-14.29%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/123/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/123?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/123?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [10ef42c...d55d844](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/123?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).