fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 10 forks source link

Fix get recordings spec #124

Closed Karolk99 closed 9 months ago

Karolk99 commented 9 months ago

Acknowledging the stipulations set forth:

codecov[bot] commented 9 months ago

Codecov Report

Merging #124 (4ca1e60) into main (6538d54) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #124 +/- ## ======================================= Coverage 86.18% 86.18% ======================================= Files 54 54 Lines 992 992 ======================================= Hits 855 855 Misses 137 137 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish\_web/controllers/recording\_json.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvcmVjb3JkaW5nX2pzb24uZXg=) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/124?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/124?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [6538d54...4ca1e60](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/124?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).
Karolk99 commented 9 months ago

It isn't the scope of this PR, but we should think about a way to check the returned JSON structure with generated OpenApiSpec automatically.

https://membraneframework.atlassian.net/jira/software/c/projects/RTC/boards/18/backlog?selectedIssue=RTC-419