fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 10 forks source link

[RTC-426] Allow for assigning custom room id #133

Closed roznawsk closed 8 months ago

roznawsk commented 8 months ago

Acknowledging the stipulations set forth:

codecov[bot] commented 8 months ago

Codecov Report

Merging #133 (041f27c) into main (0a8e8d5) will increase coverage by 0.00%. The diff coverage is 95.23%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #133 +/- ## ======================================= Coverage 86.90% 86.91% ======================================= Files 59 59 Lines 1054 1062 +8 ======================================= + Hits 916 923 +7 - Misses 138 139 +1 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tLmV4) | `86.79% <100.00%> (ø)` | | | [lib/jellyfish/room\_service.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tX3NlcnZpY2UuZXg=) | `84.84% <100.00%> (+0.23%)` | :arrow_up: | | [lib/jellyfish\_web/api\_spec/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvcm9vbS5leA==) | `100.00% <ø> (ø)` | | | [lib/jellyfish\_web/controllers/room\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvcm9vbV9jb250cm9sbGVyLmV4) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/room/config.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tL2NvbmZpZy5leA==) | `90.90% <83.33%> (-3.21%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/133?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/133?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [0a8e8d5...041f27c](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/133?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).