fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 10 forks source link

[RTC-419] Standardise Jellyfish API test #134

Closed roznawsk closed 8 months ago

roznawsk commented 8 months ago

Separate tests for each component

Acknowledging the stipulations set forth:

codecov[bot] commented 8 months ago

Codecov Report

Merging #134 (7d03b43) into main (d7c1ab1) will decrease coverage by 0.26%. The diff coverage is 82.75%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #134 +/- ## ========================================== - Coverage 86.91% 86.66% -0.26% ========================================== Files 59 60 +1 Lines 1062 1087 +25 ========================================== + Hits 923 942 +19 - Misses 139 145 +6 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/component/file.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvZmlsZS5leA==) | `100.00% <100.00%> (ø)` | | | [.../jellyfish\_web/controllers/component\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvY29tcG9uZW50X2NvbnRyb2xsZXIuZXg=) | `86.36% <100.00%> (+0.64%)` | :arrow_up: | | [test/support/component\_case.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-dGVzdC9zdXBwb3J0L2NvbXBvbmVudF9jYXNlLmV4) | `100.00% <100.00%> (ø)` | | | [test/support/conn\_case.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-dGVzdC9zdXBwb3J0L2Nvbm5fY2FzZS5leA==) | `100.00% <ø> (ø)` | | | [lib/jellyfish/component/rtsp.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvcnRzcC5leA==) | `83.33% <0.00%> (-16.67%)` | :arrow_down: | | [lib/jellyfish/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tLmV4) | `83.83% <55.55%> (-2.97%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/134/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/134?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/134?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [d7c1ab1...7d03b43](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/134?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).