fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 10 forks source link

Refactor file and rtsp component tests #135

Closed Karolk99 closed 8 months ago

Karolk99 commented 8 months ago

Acknowledging the stipulations set forth:

Some tests were removed instead of moving them to controller tests because they were redundant also some tests stayed in jellyfish/component folder because they don't return any properties.

codecov[bot] commented 8 months ago

Codecov Report

Merging #135 (bb8f383) into main (7dac6c5) will increase coverage by 0.55%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #135 +/- ## ========================================== + Coverage 86.66% 87.21% +0.55% ========================================== Files 60 60 Lines 1087 1087 ========================================== + Hits 942 948 +6 + Misses 145 139 -6 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/135/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/135?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/135?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [7dac6c5...bb8f383](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/135?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).