fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 10 forks source link

[RTC-405] Resolve FQDNs in DNS cluster strategy #137

Closed mickel8 closed 8 months ago

mickel8 commented 8 months ago

After this PR:

RELEASE_NODE=<JF_DIST_NODE_NAME(resolved in case of DNS)> RELEASE_COOKIE= RELEASE_DISTRIBUTION= _build/../jellyfish remote

To be precise, not always all of the above ones but this is quite tricky to describe

Documentation update jellyfish-dev/jellyfish-docs#72

Acknowledging the stipulations set forth:

codecov[bot] commented 8 months ago

Codecov Report

Merging #137 (e0e8a55) into main (966ac7d) will decrease coverage by 0.09%. Report is 1 commits behind head on main. The diff coverage is 85.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #137 +/- ## ========================================== - Coverage 87.21% 87.12% -0.09% ========================================== Files 60 60 Lines 1087 1103 +16 ========================================== + Hits 948 961 +13 - Misses 139 142 +3 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/application.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9hcHBsaWNhdGlvbi5leA==) | `50.00% <0.00%> (ø)` | | | [lib/jellyfish/config\_reader.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb25maWdfcmVhZGVyLmV4) | `93.61% <88.46%> (-2.54%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/137?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/137?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [966ac7d...e0e8a55](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/137?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).