fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 10 forks source link

[RTC-435] Add tracks and their metadata #141

Closed roznawsk closed 6 months ago

roznawsk commented 7 months ago

Check out PR in protos: https://github.com/jellyfish-dev/jellyfish/pull/141

Acknowledging the stipulations set forth:

codecov[bot] commented 7 months ago

Codecov Report

Merging #141 (ff8556a) into main (8f6e1ca) will decrease coverage by 1.13%. The diff coverage is 76.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #141 +/- ## ========================================== - Coverage 87.77% 86.65% -1.13% ========================================== Files 62 64 +2 Lines 1137 1221 +84 ========================================== + Hits 998 1058 +60 - Misses 139 163 +24 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/component.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQuZXg=) | `100.00% <ø> (ø)` | | | [lib/jellyfish/peer.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9wZWVyLmV4) | `85.71% <ø> (ø)` | | | [lib/jellyfish/peer/webrtc.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9wZWVyL3dlYnJ0Yy5leA==) | `48.27% <ø> (ø)` | | | [lib/jellyfish/room\_service.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tX3NlcnZpY2UuZXg=) | `86.30% <ø> (-0.19%)` | :arrow_down: | | [lib/jellyfish/track.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC90cmFjay5leA==) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/webhook\_notifier.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC93ZWJob29rX25vdGlmaWVyLmV4) | `78.94% <ø> (ø)` | | | [lib/jellyfish\_web/api\_spec/component/file.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvY29tcG9uZW50L2ZpbGUuZXg=) | `100.00% <ø> (ø)` | | | [lib/jellyfish\_web/api\_spec/component/hls.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvY29tcG9uZW50L2hscy5leA==) | `100.00% <ø> (ø)` | | | [lib/jellyfish\_web/api\_spec/component/rtsp.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvY29tcG9uZW50L3J0c3AuZXg=) | `100.00% <ø> (ø)` | | | [lib/jellyfish\_web/api\_spec/peer.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvcGVlci5leA==) | `100.00% <100.00%> (ø)` | | | ... and [8 more](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [8f6e1ca...ff8556a](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/141?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).