fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 10 forks source link

File component framerate #145

Closed Rados13 closed 7 months ago

Rados13 commented 7 months ago

Acknowledging the stipulations set forth:

Docs PR Elixir SDK PR Python SDK PR

codecov[bot] commented 7 months ago

Codecov Report

Merging #145 (d946fd0) into main (f671621) will increase coverage by 0.18%. The diff coverage is 96.96%.

:exclamation: Current head d946fd0 differs from pull request most recent head 62f8e6f. Consider uploading reports for the commit 62f8e6f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #145 +/- ## ========================================== + Coverage 87.34% 87.52% +0.18% ========================================== Files 59 59 Lines 1098 1114 +16 ========================================== + Hits 959 975 +16 Misses 139 139 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/component/file.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvZmlsZS5leA==) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/config\_reader.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb25maWdfcmVhZGVyLmV4) | `93.61% <ø> (ø)` | | | [lib/jellyfish/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tLmV4) | `86.62% <100.00%> (+0.31%)` | :arrow_up: | | [lib/jellyfish/room\_service.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tX3NlcnZpY2UuZXg=) | `86.48% <100.00%> (ø)` | | | [lib/jellyfish\_web/api\_spec/component/file.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvY29tcG9uZW50L2ZpbGUuZXg=) | `100.00% <ø> (ø)` | | | [.../jellyfish\_web/controllers/component\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvY29tcG9uZW50X2NvbnRyb2xsZXIuZXg=) | `95.83% <100.00%> (+0.37%)` | :arrow_up: | | [lib/jellyfish/component/hls/request\_handler.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvaGxzL3JlcXVlc3RfaGFuZGxlci5leA==) | `91.89% <85.71%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/145?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/145?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [f671621...62f8e6f](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/145?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).