fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 10 forks source link

[RTC-471] Fix auth not required for /hls and /recording requests #153

Closed sgfn closed 6 months ago

sgfn commented 6 months ago

Acknowledging the stipulations set forth:

codecov[bot] commented 6 months ago

Codecov Report

Merging #153 (d1a7f1a) into main (a403ecc) will not change coverage. Report is 1 commits behind head on main. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #153 +/- ## ======================================= Coverage 86.63% 86.63% ======================================= Files 64 64 Lines 1227 1227 ======================================= Hits 1063 1063 Misses 164 164 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [...ellyfish\_web/controllers/healthcheck\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvaGVhbHRoY2hlY2tfY29udHJvbGxlci5leA==) | `100.00% <ø> (ø)` | | | [.../jellyfish\_web/controllers/recording\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvcmVjb3JkaW5nX2NvbnRyb2xsZXIuZXg=) | `88.88% <ø> (ø)` | | | [...llyfish\_web/controllers/subscription\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvc3Vic2NyaXB0aW9uX2NvbnRyb2xsZXIuZXg=) | `88.88% <ø> (ø)` | | | [lib/jellyfish\_web/router.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvcm91dGVyLmV4) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/153?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/153?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [a403ecc...d1a7f1a](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/153?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).