fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 10 forks source link

[RTC-478] Propagate peer crash reason #161

Closed roznawsk closed 6 months ago

roznawsk commented 6 months ago

ref: https://github.com/jellyfish-dev/protos/pull/16 https://github.com/jellyfish-dev/membrane_rtc_engine/pull/368

Acknowledging the stipulations set forth:

roznawsk commented 6 months ago

CI fails @Rados13

We need to merge proto first

codecov[bot] commented 6 months ago

Codecov Report

Merging #161 (2e9755c) into main (f9ff413) will increase coverage by 0.26%. The diff coverage is 25.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #161 +/- ## ========================================== + Coverage 86.10% 86.37% +0.26% ========================================== Files 69 69 Lines 1303 1306 +3 ========================================== + Hits 1122 1128 +6 + Misses 181 178 -3 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/event.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9ldmVudC5leA==) | `90.32% <0.00%> (+3.22%)` | :arrow_up: | | [lib/jellyfish\_web/peer\_socket.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvcGVlcl9zb2NrZXQuZXg=) | `84.09% <0.00%> (-1.96%)` | :arrow_down: | | [lib/jellyfish/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tLmV4) | `81.17% <33.33%> (+1.42%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/161?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/161?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [f9ff413...2e9755c](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/161?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).