fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
187 stars 10 forks source link

Add recording component #165

Closed Karolk99 closed 4 months ago

Karolk99 commented 4 months ago

Acknowledging the stipulations set forth:

codecov[bot] commented 4 months ago

Codecov Report

Merging #165 (7b6ee2c) into main (d47cfa9) will increase coverage by 0.85%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #165 +/- ## ========================================== + Coverage 86.10% 86.96% +0.85% ========================================== Files 70 72 +2 Lines 1317 1350 +33 ========================================== + Hits 1134 1174 +40 + Misses 183 176 -7 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/165?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/component.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/165?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQuZXg=) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/component/recording.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/165?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvcmVjb3JkaW5nLmV4) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/config\_reader.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/165?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb25maWdfcmVhZGVyLmV4) | `94.64% <100.00%> (+0.52%)` | :arrow_up: | | [lib/jellyfish/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/165?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tLmV4) | `83.13% <100.00%> (+2.97%)` | :arrow_up: | | [lib/jellyfish\_web/api\_spec/component.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/165?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvY29tcG9uZW50LmV4) | `100.00% <ø> (ø)` | | | [lib/jellyfish\_web/api\_spec/component/recording.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/165?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvY29tcG9uZW50L3JlY29yZGluZy5leA==) | `100.00% <100.00%> (ø)` | | | [.../jellyfish\_web/controllers/component\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/165?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvY29tcG9uZW50X2NvbnRyb2xsZXIuZXg=) | `96.00% <100.00%> (+0.16%)` | :arrow_up: | | [lib/jellyfish\_web/controllers/component\_json.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/165?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvY29tcG9uZW50X2pzb24uZXg=) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/165?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/165?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [d47cfa9...7b6ee2c](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/165?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).