fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
203 stars 16 forks source link

Restrict available codecs in room for recording component #169

Closed Karolk99 closed 8 months ago

Karolk99 commented 8 months ago

Acknowledging the stipulations set forth:

codecov[bot] commented 8 months ago

Codecov Report

Merging #169 (0a56477) into main (3891613) will decrease coverage by 0.16%. The diff coverage is 78.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #169 +/- ## ========================================== - Coverage 86.96% 86.80% -0.16% ========================================== Files 72 72 Lines 1350 1364 +14 ========================================== + Hits 1174 1184 +10 - Misses 176 180 +4 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/169?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/169?src=pr&el=tree&filepath=lib%2Fjellyfish%2Froom.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tLmV4) | `83.20% <100.00%> (+0.06%)` | :arrow_up: | | [.../jellyfish\_web/controllers/component\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/169?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Fcontrollers%2Fcomponent_controller.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvY29tcG9uZW50X2NvbnRyb2xsZXIuZXg=) | `96.15% <100.00%> (+0.15%)` | :arrow_up: | | [test/support/component\_case.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/169?src=pr&el=tree&filepath=test%2Fsupport%2Fcomponent_case.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-dGVzdC9zdXBwb3J0L2NvbXBvbmVudF9jYXNlLmV4) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/component.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/169?src=pr&el=tree&filepath=lib%2Fjellyfish%2Fcomponent.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQuZXg=) | `75.00% <42.85%> (-25.00%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/169?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/169?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [3891613...0a56477](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/169?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).