fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
187 stars 10 forks source link

Add JF_S3_PATH_PREFIX to config and restrict s3_config to be provided… #170

Closed Karolk99 closed 3 months ago

Karolk99 commented 3 months ago

… through only one method

Acknowledging the stipulations set forth:

codecov[bot] commented 3 months ago

Codecov Report

Merging #170 (b3faeef) into main (6d3b5a3) will decrease coverage by 0.05%. The diff coverage is 91.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #170 +/- ## ========================================== - Coverage 86.80% 86.75% -0.05% ========================================== Files 72 72 Lines 1364 1382 +18 ========================================== + Hits 1184 1199 +15 - Misses 180 183 +3 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/170?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/config\_reader.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/170?src=pr&el=tree&filepath=lib%2Fjellyfish%2Fconfig_reader.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb25maWdfcmVhZGVyLmV4) | `94.73% <100.00%> (+0.09%)` | :arrow_up: | | [lib/jellyfish/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/170?src=pr&el=tree&filepath=lib%2Fjellyfish%2Froom.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tLmV4) | `83.46% <100.00%> (+0.26%)` | :arrow_up: | | [.../jellyfish\_web/controllers/component\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/170?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Fcontrollers%2Fcomponent_controller.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvY29tcG9uZW50X2NvbnRyb2xsZXIuZXg=) | `96.42% <100.00%> (+0.27%)` | :arrow_up: | | [lib/jellyfish/component/recording.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/170?src=pr&el=tree&filepath=lib%2Fjellyfish%2Fcomponent%2Frecording.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvcmVjb3JkaW5nLmV4) | `88.00% <84.21%> (-12.00%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/170?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/170?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [6d3b5a3...b3faeef](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/170?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).