fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
201 stars 15 forks source link

Fix recording component request #172

Closed Karolk99 closed 6 months ago

Karolk99 commented 6 months ago

Acknowledging the stipulations set forth:

codecov[bot] commented 6 months ago

Codecov Report

Merging #172 (2d5746a) into main (8bc4145) will increase coverage by 0.07%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #172 +/- ## ========================================== + Coverage 87.19% 87.26% +0.07% ========================================== Files 72 72 Lines 1382 1382 ========================================== + Hits 1205 1206 +1 + Misses 177 176 -1 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish\_web/api\_spec/component/recording.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/172?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Fapi_spec%2Fcomponent%2Frecording.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvY29tcG9uZW50L3JlY29yZGluZy5leA==) | `100.00% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/172?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/172?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [8bc4145...2d5746a](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/172?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).