fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
187 stars 10 forks source link

RTC-510 Recording manual subscribe mode #174

Closed Rados13 closed 3 months ago

Rados13 commented 3 months ago

Acknowledging the stipulations set forth:

PR in Elixir SDK PR in Python SDK PR in Docs

codecov[bot] commented 3 months ago

Codecov Report

Merging #174 (f34722d) into main (e9a5f3c) will decrease coverage by 0.35%. The diff coverage is 95.23%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #174 +/- ## ========================================== - Coverage 87.31% 86.97% -0.35% ========================================== Files 72 72 Lines 1388 1397 +9 ========================================== + Hits 1212 1215 +3 - Misses 176 182 +6 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/174?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/component/recording.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/174?src=pr&el=tree&filepath=lib%2Fjellyfish%2Fcomponent%2Frecording.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvcmVjb3JkaW5nLmV4) | `96.87% <100.00%> (+4.01%)` | :arrow_up: | | [lib/jellyfish\_web/api\_spec/component/recording.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/174?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Fapi_spec%2Fcomponent%2Frecording.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvY29tcG9uZW50L3JlY29yZGluZy5leA==) | `100.00% <ø> (ø)` | | | [...llyfish\_web/controllers/subscription\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/174?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Fcontrollers%2Fsubscription_controller.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvc3Vic2NyaXB0aW9uX2NvbnRyb2xsZXIuZXg=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: | | [lib/jellyfish\_web/router.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/174?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Frouter.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvcm91dGVyLmV4) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/174?src=pr&el=tree&filepath=lib%2Fjellyfish%2Froom.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tLmV4) | `83.26% <90.90%> (-2.17%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/174/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/174?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/174?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [e9a5f3c...f34722d](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/174?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).