fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
201 stars 15 forks source link

RTC-512 Add Room.State module and peer disconnected timeout #178

Closed Rados13 closed 5 months ago

Rados13 commented 5 months ago

This PR introduces two changes:

Acknowledging the stipulations set forth:

PR to docs PR to elixir SDK PR to Python SDK

codecov[bot] commented 5 months ago

Codecov Report

Merging #178 (1e308e6) into main (67bf454) will increase coverage by 0.36%. The diff coverage is 87.61%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #178 +/- ## ========================================== + Coverage 86.88% 87.24% +0.36% ========================================== Files 73 74 +1 Lines 1433 1482 +49 ========================================== + Hits 1245 1293 +48 - Misses 188 189 +1 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/178?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/peer.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/178?src=pr&el=tree&filepath=lib%2Fjellyfish%2Fpeer.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9wZWVyLmV4) | `85.71% <ø> (ø)` | | | [lib/jellyfish/room/config.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/178?src=pr&el=tree&filepath=lib%2Fjellyfish%2Froom%2Fconfig.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tL2NvbmZpZy5leA==) | `96.42% <100.00%> (+0.27%)` | :arrow_up: | | [lib/jellyfish/room\_service.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/178?src=pr&el=tree&filepath=lib%2Fjellyfish%2Froom_service.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tX3NlcnZpY2UuZXg=) | `87.01% <100.00%> (ø)` | | | [lib/jellyfish\_web/api\_spec/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/178?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Fapi_spec%2Froom.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvcm9vbS5leA==) | `100.00% <ø> (ø)` | | | [lib/jellyfish\_web/controllers/room\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/178?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Fcontrollers%2Froom_controller.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvcm9vbV9jb250cm9sbGVyLmV4) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish\_web/peer\_socket.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/178?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Fpeer_socket.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvcGVlcl9zb2NrZXQuZXg=) | `82.00% <71.42%> (-2.10%)` | :arrow_down: | | [lib/jellyfish/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/178?src=pr&el=tree&filepath=lib%2Fjellyfish%2Froom.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tLmV4) | `83.10% <86.27%> (-0.17%)` | :arrow_down: | | [lib/jellyfish/room/state.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/178?src=pr&el=tree&filepath=lib%2Fjellyfish%2Froom%2Fstate.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tL3N0YXRlLmV4) | `88.07% <88.07%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/178/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/178?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/178?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [67bf454...1e308e6](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/178?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).