fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
201 stars 15 forks source link

Return peer_websocket_url in PeerDetailsResponse #181

Closed Rados13 closed 5 months ago

Rados13 commented 5 months ago

This PR introduces two changes:

Acknowledging the stipulations set forth:

Docs PR Elixir SDK PR Python SDK PR

codecov[bot] commented 5 months ago

Codecov Report

Merging #181 (e9b39a5) into main (9cfc3e0) will increase coverage by 0.01%. The diff coverage is 91.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #181 +/- ## ========================================== + Coverage 86.84% 86.85% +0.01% ========================================== Files 74 74 Lines 1482 1491 +9 ========================================== + Hits 1287 1295 +8 - Misses 195 196 +1 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/181?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/181?src=pr&el=tree&filepath=lib%2Fjellyfish.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC5leA==) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/room\_service.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/181?src=pr&el=tree&filepath=lib%2Fjellyfish%2Froom_service.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tX3NlcnZpY2UuZXg=) | `87.01% <100.00%> (ø)` | | | [lib/jellyfish\_web/api\_spec/peer.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/181?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Fapi_spec%2Fpeer.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvcGVlci5leA==) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish\_web/api\_spec/responses.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/181?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Fapi_spec%2Fresponses.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvcmVzcG9uc2VzLmV4) | `100.00% <ø> (ø)` | | | [lib/jellyfish\_web/controllers/peer\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/181?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Fcontrollers%2Fpeer_controller.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvcGVlcl9jb250cm9sbGVyLmV4) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish\_web/controllers/peer\_json.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/181?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Fcontrollers%2Fpeer_json.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvcGVlcl9qc29uLmV4) | `90.00% <100.00%> (ø)` | | | [lib/jellyfish/resource\_manager.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/181?src=pr&el=tree&filepath=lib%2Fjellyfish%2Fresource_manager.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yZXNvdXJjZV9tYW5hZ2VyLmV4) | `97.14% <80.00%> (-2.86%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/181?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/181?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [9cfc3e0...e9b39a5](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/181?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).
Rados13 commented 5 months ago

LGTM, why are we introducing this change though?

@kamil-stasiak requested these changes as they could simplify logic in back-end and front-end code.