fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
187 stars 10 forks source link

[RTC-526] Add env vars to configure allowed components #189

Closed sgfn closed 2 months ago

sgfn commented 2 months ago

This PR introduces a breaking change: users must now specify which components they wish to use using the JF_COMPONENTS_USED environment variable.

ref: https://github.com/jellyfish-dev/jellyfish-docs/pull/108

Acknowledging the stipulations set forth:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 97.91667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.66%. Comparing base (5a96434) to head (839c587). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #189 +/- ## ========================================== + Coverage 87.46% 87.66% +0.19% ========================================== Files 74 74 Lines 1500 1516 +16 ========================================== + Hits 1312 1329 +17 + Misses 188 187 -1 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/189?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/application.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/189?src=pr&el=tree&filepath=lib%2Fjellyfish%2Fapplication.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9hcHBsaWNhdGlvbi5leA==) | `60.00% <100.00%> (+2.85%)` | :arrow_up: | | [lib/jellyfish/component/recording.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/189?src=pr&el=tree&filepath=lib%2Fjellyfish%2Fcomponent%2Frecording.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvcmVjb3JkaW5nLmV4) | `100.00% <ø> (+3.12%)` | :arrow_up: | | [lib/jellyfish/component/sip.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/189?src=pr&el=tree&filepath=lib%2Fjellyfish%2Fcomponent%2Fsip.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvc2lwLmV4) | `85.71% <100.00%> (+5.71%)` | :arrow_up: | | [lib/jellyfish/config\_reader.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/189?src=pr&el=tree&filepath=lib%2Fjellyfish%2Fconfig_reader.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb25maWdfcmVhZGVyLmV4) | `96.66% <100.00%> (+0.11%)` | :arrow_up: | | [lib/jellyfish/peer/webrtc.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/189?src=pr&el=tree&filepath=lib%2Fjellyfish%2Fpeer%2Fwebrtc.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9wZWVyL3dlYnJ0Yy5leA==) | `48.14% <ø> (-0.13%)` | :arrow_down: | | [lib/jellyfish/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/189?src=pr&el=tree&filepath=lib%2Fjellyfish%2Froom.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tLmV4) | `83.87% <100.00%> (+0.87%)` | :arrow_up: | | [lib/jellyfish/room/state.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/189?src=pr&el=tree&filepath=lib%2Fjellyfish%2Froom%2Fstate.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tL3N0YXRlLmV4) | `88.34% <100.00%> (-0.20%)` | :arrow_down: | | [.../jellyfish\_web/controllers/component\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/189?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Fcontrollers%2Fcomponent_controller.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvY29tcG9uZW50X2NvbnRyb2xsZXIuZXg=) | `96.42% <100.00%> (ø)` | | | [lib/jellyfish\_web/controllers/peer\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/189?src=pr&el=tree&filepath=lib%2Fjellyfish_web%2Fcontrollers%2Fpeer_controller.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvcGVlcl9jb250cm9sbGVyLmV4) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/peer.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/189?src=pr&el=tree&filepath=lib%2Fjellyfish%2Fpeer.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9wZWVyLmV4) | `80.00% <66.66%> (-5.72%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/189?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/189?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [5a96434...839c587](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/189?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).