fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
187 stars 10 forks source link

Add logs about errors during adding peer #191

Closed Rados13 closed 1 month ago

Rados13 commented 2 months ago

Acknowledging the stipulations set forth:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 87.19%. Comparing base (07a89a9) to head (070852c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #191 +/- ## ========================================== + Coverage 86.89% 87.19% +0.30% ========================================== Files 77 77 Lines 1549 1570 +21 ========================================== + Hits 1346 1369 +23 + Misses 203 201 -2 ``` | [Files](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/191?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) | Coverage Δ | | |---|---|---| | [lib/fishjam\_web/controllers/fallback\_controller.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/191?src=pr&el=tree&filepath=lib%2Ffishjam_web%2Fcontrollers%2Ffallback_controller.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW1fd2ViL2NvbnRyb2xsZXJzL2ZhbGxiYWNrX2NvbnRyb2xsZXIuZXg=) | `100.00% <100.00%> (ø)` | | | [lib/fishjam\_web/controllers/peer\_controller.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/191?src=pr&el=tree&filepath=lib%2Ffishjam_web%2Fcontrollers%2Fpeer_controller.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW1fd2ViL2NvbnRyb2xsZXJzL3BlZXJfY29udHJvbGxlci5leA==) | `100.00% <100.00%> (ø)` | | | [lib/fishjam/room\_service.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/191?src=pr&el=tree&filepath=lib%2Ffishjam%2Froom_service.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vcm9vbV9zZXJ2aWNlLmV4) | `83.78% <60.00%> (-1.73%)` | :arrow_down: | | [lib/fishjam\_web/controllers/room\_controller.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/191?src=pr&el=tree&filepath=lib%2Ffishjam_web%2Fcontrollers%2Froom_controller.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW1fd2ViL2NvbnRyb2xsZXJzL3Jvb21fY29udHJvbGxlci5leA==) | `94.87% <33.33%> (-5.13%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/191/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/191?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/191?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Last update [07a89a9...070852c](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/191?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev).
roznawsk commented 1 month ago

Do we want to merge this PR?