fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
201 stars 15 forks source link

Feat/introduce ADRs #200

Closed kamciokodzi closed 4 months ago

kamciokodzi commented 4 months ago

Acknowledging the stipulations set forth:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.92%. Comparing base (465ae81) to head (aaefe0e). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #200 +/- ## ========================================== - Coverage 87.32% 86.92% -0.40% ========================================== Files 74 74 Lines 1530 1530 ========================================== - Hits 1336 1330 -6 - Misses 194 200 +6 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/200/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/200?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/200?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Last update [465ae81...aaefe0e](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/200?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev).
kamciokodzi commented 4 months ago

Awesome, I added a few minor comments 👍 Also, what are we going to do with the old design docs? Maybe create a new directory for them called old?

Well I assumed here that we won't write ADRs for old decisions. I wouldn't also call them old since they are up to date with the current architecture. I don't mind having them laying around in the docs folder, but I'm open to suggestions.