fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
201 stars 15 forks source link

[RTC-548] Allow underscore in room IDs, rename leftover files #201

Closed sgfn closed 4 months ago

sgfn commented 4 months ago

Acknowledging the stipulations set forth:

ref: https://github.com/fishjam-dev/fishjam-docs/pull/113

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.23%. Comparing base (64f7e38) to head (f809dc5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #201 +/- ## ======================================= Coverage 87.23% 87.23% ======================================= Files 74 74 Lines 1536 1536 ======================================= Hits 1340 1340 Misses 196 196 ``` | [Files](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) | Coverage Δ | | |---|---|---| | [lib/fishjam.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?src=pr&el=tree&filepath=lib%2Ffishjam.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0uZXg=) | `100.00% <ø> (ø)` | | | [lib/fishjam/application.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?src=pr&el=tree&filepath=lib%2Ffishjam%2Fapplication.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vYXBwbGljYXRpb24uZXg=) | `51.42% <ø> (ø)` | | | [lib/fishjam/component.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?src=pr&el=tree&filepath=lib%2Ffishjam%2Fcomponent.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vY29tcG9uZW50LmV4) | `75.00% <ø> (ø)` | | | [lib/fishjam/component/file.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?src=pr&el=tree&filepath=lib%2Ffishjam%2Fcomponent%2Ffile.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vY29tcG9uZW50L2ZpbGUuZXg=) | `100.00% <ø> (ø)` | | | [lib/fishjam/component/hls.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?src=pr&el=tree&filepath=lib%2Ffishjam%2Fcomponent%2Fhls.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vY29tcG9uZW50L2hscy5leA==) | `96.77% <ø> (ø)` | | | [lib/fishjam/component/hls/ets\_helper.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?src=pr&el=tree&filepath=lib%2Ffishjam%2Fcomponent%2Fhls%2Fets_helper.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vY29tcG9uZW50L2hscy9ldHNfaGVscGVyLmV4) | `100.00% <ø> (ø)` | | | [lib/fishjam/component/hls/httpoison.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?src=pr&el=tree&filepath=lib%2Ffishjam%2Fcomponent%2Fhls%2Fhttpoison.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vY29tcG9uZW50L2hscy9odHRwb2lzb24uZXg=) | `0.00% <ø> (ø)` | | | [lib/fishjam/component/hls/ll\_storage.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?src=pr&el=tree&filepath=lib%2Ffishjam%2Fcomponent%2Fhls%2Fll_storage.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vY29tcG9uZW50L2hscy9sbF9zdG9yYWdlLmV4) | `76.31% <ø> (ø)` | | | [lib/fishjam/component/hls/manager.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?src=pr&el=tree&filepath=lib%2Ffishjam%2Fcomponent%2Fhls%2Fmanager.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vY29tcG9uZW50L2hscy9tYW5hZ2VyLmV4) | `97.05% <ø> (ø)` | | | [lib/fishjam/component/hls/recording.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?src=pr&el=tree&filepath=lib%2Ffishjam%2Fcomponent%2Fhls%2Frecording.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vY29tcG9uZW50L2hscy9yZWNvcmRpbmcuZXg=) | `89.47% <ø> (ø)` | | | ... and [59 more](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Last update [64f7e38...f809dc5](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/201?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev).