fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
187 stars 10 forks source link

Fix HLS OpenAPI warning #202

Closed Rados13 closed 1 month ago

Rados13 commented 1 month ago

Acknowledging the stipulations set forth:

OpenAPI warning is fixed by how object S3Credentials is referenced. Error with AuthCache was fixed by providing AuthConfigAdapter, which is the way AuthCache is tested in ExAws.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.08%. Comparing base (9b57b35) to head (eeac9f0). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #202 +/- ## ========================================== - Coverage 87.12% 87.08% -0.04% ========================================== Files 74 76 +2 Lines 1538 1541 +3 ========================================== + Hits 1340 1342 +2 - Misses 198 199 +1 ``` | [Files](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/202?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) | Coverage Δ | | |---|---|---| | [lib/fishjam/component/hls/manager.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/202?src=pr&el=tree&filepath=lib%2Ffishjam%2Fcomponent%2Fhls%2Fmanager.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vY29tcG9uZW50L2hscy9tYW5hZ2VyLmV4) | `97.14% <100.00%> (+0.08%)` | :arrow_up: | | [lib/fishjam/room\_service.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/202?src=pr&el=tree&filepath=lib%2Ffishjam%2Froom_service.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vcm9vbV9zZXJ2aWNlLmV4) | `87.01% <100.00%> (ø)` | | | [lib/fishjam\_web/api\_spec/component/HLS/S3.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/202?src=pr&el=tree&filepath=lib%2Ffishjam_web%2Fapi_spec%2Fcomponent%2FHLS%2FS3.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW1fd2ViL2FwaV9zcGVjL2NvbXBvbmVudC9ITFMvUzMuZXg=) | `100.00% <100.00%> (ø)` | | | [lib/fishjam\_web/api\_spec/component/hls.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/202?src=pr&el=tree&filepath=lib%2Ffishjam_web%2Fapi_spec%2Fcomponent%2Fhls.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW1fd2ViL2FwaV9zcGVjL2NvbXBvbmVudC9obHMuZXg=) | `100.00% <ø> (ø)` | | | [lib/fishjam\_web/api\_spec/component/recording.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/202?src=pr&el=tree&filepath=lib%2Ffishjam_web%2Fapi_spec%2Fcomponent%2Frecording.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW1fd2ViL2FwaV9zcGVjL2NvbXBvbmVudC9yZWNvcmRpbmcuZXg=) | `100.00% <ø> (ø)` | | | [lib/fishjam\_web/peer\_socket.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/202?src=pr&el=tree&filepath=lib%2Ffishjam_web%2Fpeer_socket.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW1fd2ViL3BlZXJfc29ja2V0LmV4) | `82.00% <100.00%> (ø)` | | | [test/support/mock\_manager.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/202?src=pr&el=tree&filepath=test%2Fsupport%2Fmock_manager.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-dGVzdC9zdXBwb3J0L21vY2tfbWFuYWdlci5leA==) | `100.00% <100.00%> (ø)` | | | [test/support/adapter.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/202?src=pr&el=tree&filepath=test%2Fsupport%2Fadapter.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-dGVzdC9zdXBwb3J0L2FkYXB0ZXIuZXg=) | `0.00% <0.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/202?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/202?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Last update [9b57b35...eeac9f0](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/202?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev).