fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
201 stars 15 forks source link

feat: introduce room_id generator #206

Closed kamciokodzi closed 4 months ago

kamciokodzi commented 4 months ago

This PR introduces:

Docs

Acknowledging the stipulations set forth:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 70.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 86.89%. Comparing base (0b3270f) to head (25da293). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #206 +/- ## ========================================== - Coverage 87.12% 86.89% -0.24% ========================================== Files 74 77 +3 Lines 1538 1549 +11 ========================================== + Hits 1340 1346 +6 - Misses 198 203 +5 ``` | [Files](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/206?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) | Coverage Δ | | |---|---|---| | [lib/fishjam/application.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/206?src=pr&el=tree&filepath=lib%2Ffishjam%2Fapplication.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vYXBwbGljYXRpb24uZXg=) | `48.64% <ø> (ø)` | | | [lib/fishjam/component/file.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/206?src=pr&el=tree&filepath=lib%2Ffishjam%2Fcomponent%2Ffile.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vY29tcG9uZW50L2ZpbGUuZXg=) | `100.00% <ø> (ø)` | | | [lib/fishjam/component/hls/recording.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/206?src=pr&el=tree&filepath=lib%2Ffishjam%2Fcomponent%2Fhls%2Frecording.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vY29tcG9uZW50L2hscy9yZWNvcmRpbmcuZXg=) | `89.47% <100.00%> (ø)` | | | [lib/fishjam/component/hls/request\_handler.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/206?src=pr&el=tree&filepath=lib%2Ffishjam%2Fcomponent%2Fhls%2Frequest_handler.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vY29tcG9uZW50L2hscy9yZXF1ZXN0X2hhbmRsZXIuZXg=) | `91.89% <100.00%> (ø)` | | | [lib/fishjam/feature\_flags.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/206?src=pr&el=tree&filepath=lib%2Ffishjam%2Ffeature_flags.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vZmVhdHVyZV9mbGFncy5leA==) | `100.00% <100.00%> (ø)` | | | [lib/fishjam/room/config.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/206?src=pr&el=tree&filepath=lib%2Ffishjam%2Froom%2Fconfig.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vcm9vbS9jb25maWcuZXg=) | `100.00% <100.00%> (+3.57%)` | :arrow_up: | | [lib/fishjam/room/id.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/206?src=pr&el=tree&filepath=lib%2Ffishjam%2Froom%2Fid.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vcm9vbS9pZC5leA==) | `91.66% <91.66%> (ø)` | | | [lib/fishjam/room\_service.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/206?src=pr&el=tree&filepath=lib%2Ffishjam%2Froom_service.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vcm9vbV9zZXJ2aWNlLmV4) | `85.50% <40.00%> (-1.51%)` | :arrow_down: | | [lib/fishjam/rpc\_client.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/206?src=pr&el=tree&filepath=lib%2Ffishjam%2Frpc_client.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW0vcnBjX2NsaWVudC5leA==) | `44.44% <44.44%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/206?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/206?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Last update [0b3270f...25da293](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/206?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev).