fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
201 stars 15 forks source link

Allow S3 openapi to be nullable #209

Closed Rados13 closed 4 months ago

Rados13 commented 4 months ago

Acknowledging the stipulations set forth:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.77%. Comparing base (b76e35b) to head (26c7814).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #209 +/- ## ======================================= Coverage 86.77% 86.77% ======================================= Files 79 79 Lines 1573 1573 ======================================= Hits 1365 1365 Misses 208 208 ``` | [Files](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/209?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) | Coverage Δ | | |---|---|---| | [lib/fishjam\_web/api\_spec/component/HLS/S3.ex](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/209?src=pr&el=tree&filepath=lib%2Ffishjam_web%2Fapi_spec%2Fcomponent%2FHLS%2FS3.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-bGliL2Zpc2hqYW1fd2ViL2FwaV9zcGVjL2NvbXBvbmVudC9ITFMvUzMuZXg=) | `100.00% <ø> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/209?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/209?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Last update [b76e35b...26c7814](https://app.codecov.io/gh/fishjam-dev/fishjam/pull/209?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev).