fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 12 forks source link

Implement hls storage #65

Closed Karolk99 closed 1 year ago

Karolk99 commented 1 year ago

This PR is part of a larger task of adding HLS to Jellyfish. In this PR there is an implementation of HLS Storage which is the only process that communicates with HLS Endpoint.

Here is a short introduction doc.

codecov[bot] commented 1 year ago

Codecov Report

Merging #65 (a92ead6) into main (a970633) will increase coverage by 0.76%. The diff coverage is 83.54%.

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   83.78%   84.54%   +0.76%     
==========================================
  Files          36       42       +6     
  Lines         518      673     +155     
==========================================
+ Hits          434      569     +135     
- Misses         84      104      +20     
Files Changed Coverage Δ
lib/jellyfish/component/hls/storage.ex 0.00% <0.00%> (ø)
lib/jellyfish/room.ex 81.81% <40.00%> (-1.95%) :arrow_down:
lib/jellyfish/component/hls/ll_storage.ex 76.31% <76.31%> (ø)
lib/jellyfish/component/hls/request_handler.ex 90.47% <90.47%> (ø)
lib/jellyfish_web/controllers/hls_controller.ex 92.30% <92.30%> (ø)
lib/jellyfish/application.ex 80.00% <100.00%> (+2.22%) :arrow_up:
lib/jellyfish/component/hls.ex 100.00% <100.00%> (ø)
lib/jellyfish/component/hls/ets_helper.ex 100.00% <100.00%> (ø)
lib/jellyfish_web/api_spec/hls.ex 100.00% <100.00%> (ø)
lib/jellyfish_web/router.ex 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a970633...a92ead6. Read the comment docs.

Karolk99 commented 1 year ago

I will add API spec in the next commit