fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 12 forks source link

Add grafana dashboard #86

Closed Rados13 closed 11 months ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #86 (cafeda7) into main (53599d1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files          44       44           
  Lines         744      744           
=======================================
  Hits          627      627           
  Misses        117      117           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 53599d1...cafeda7. Read the comment docs.

mickel8 commented 12 months ago

Looks cool :+1: I would just remove RSS and logo for now and take care of plot colors

Thanks @Davenury for the CR :slightly_smiling_face:

Davenury commented 12 months ago

Looks cool πŸ‘ I would just remove RSS and logo for now and take care of plot colors

Thanks @Davenury for the CR πŸ™‚

You're welcome :smiley: As for the "logo" panel - I don't know the whole use case of your dashboard, yet it might be a good place to keep various things and descriptions of your system. The logo was added there (probably) for the sake of editing it to provide the mentioned information.

RSS might have been overkill, yet when your system grows, it might be a good idea to circle back to this type of panel to show recent updates, info from your company etc - look at Grafana welcome dashboard, they have that :smile:

mickel8 commented 12 months ago

Yeah exactly! But because we are on early stages of the project development, I think we don't need them right now. Especially that the project name and logo are subjects to change :)