fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 12 forks source link

Make metrics ip and port, and http endpoint port configurable #87

Closed mickel8 closed 12 months ago

mickel8 commented 12 months ago

This PR allows for running multiple JF instances in development. In particular:

codecov[bot] commented 12 months ago

Codecov Report

Merging #87 (cd00d5b) into main (bbff33a) will increase coverage by 0.56%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   83.70%   84.27%   +0.56%     
==========================================
  Files          43       44       +1     
  Lines         718      744      +26     
==========================================
+ Hits          601      627      +26     
  Misses        117      117              
Files Changed Coverage Δ
lib/jellyfish/config_reader.ex 100.00% <100.00%> (ø)
lib/jellyfish_web/telemetry.ex 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bbff33a...cd00d5b. Read the comment docs.