search

fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 12 forks source link

[RTC-345] Allow to configure HTTP endpoint IP #90

Closed mickel8 closed 11 months ago

mickel8 commented 12 months ago

We should by default bind to the 0.0.0.0 or 0.0.0.0.0.0.0.0 only when running in docker. When we run behind proxy it's better to run on a loopback not to accidentaly expose JF to the outside.

We also allow for configuring this IP env so that everyone can run on whatever port they wish

codecov[bot] commented 12 months ago

Codecov Report

Merging #90 (8de4cd5) into main (53599d1) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files          44       44           
  Lines         744      744           
=======================================
  Hits          627      627           
  Misses        117      117

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3306f50...8de4cd5. Read the comment docs.