search

fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 12 forks source link

[RTC-345] Prefix env vars with JF #91

Closed mickel8 closed 11 months ago

mickel8 commented 12 months ago

Let's follow good practices and perfix our env vars with JF not to overlap with other software.

I also deleted JELLYFISH_ADDRESS. The idea is that JF_HOST is how we are seen by the others and it's used both for generating URLs and connecting to correct Jellyfish (i.e. address returned when we create a room).

codecov[bot] commented 12 months ago

Codecov Report

Merging #91 (75452e3) into main (fe48e33) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

:exclamation: Current head 75452e3 differs from pull request most recent head 23c5bf8. Consider uploading reports for the commit 23c5bf8 to get more accurate results

@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files          44       44           
  Lines         744      744           
=======================================
  Hits          627      627           
  Misses        117      117

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b016886...23c5bf8. Read the comment docs.