search

fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 12 forks source link

[RTC-345] Always require cookie #97

Closed mickel8 closed 11 months ago

mickel8 commented 11 months ago

Setting a default cookie only for dev is possible but would be a little bit tricky so let's always require it

codecov[bot] commented 11 months ago

Codecov Report

Merging #97 (4b3c2d3) into main (5ef4452) will decrease coverage by 0.09%. Report is 1 commits behind head on main. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   83.44%   83.35%   -0.09%     
==========================================
  Files          44       44              
  Lines         767      769       +2     
==========================================
+ Hits          640      641       +1     
- Misses        127      128       +1
Files Coverage Δ
lib/jellyfish/config_reader.ex 97.43% <66.66%> (-2.57%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad1cfb6...4b3c2d3. Read the comment docs.

mickel8 commented 11 months ago

As distribution can only be used in private network (there is no encryption currently), we will keep current config as is and revisit it once we allow for running distribution globally (across different networks)