search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
141 stars 13 forks source link

Fix timestamps for paddding packets #228

Closed daniel-jodlos closed 1 year ago

daniel-jodlos commented 1 year ago

Previously, generated padding packets were given a timestamp of last RTP packet that we saw. It seemed fine, but it caused the browser to dramatically increase the jitter value and delay the stream. As a solution, a proper padding packet timestamp is estimated based on the wall clock.

codecov[bot] commented 1 year ago

Codecov Report

Merging #228 (0f833a4) into master (fb53b63) will decrease coverage by 0.11%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   56.51%   56.40%   -0.11%     
==========================================
  Files          35       35              
  Lines        1573     1576       +3     
==========================================
  Hits          889      889              
- Misses        684      687       +3
Impacted Files Coverage Δ
...membrane_rtc_engine/endpoints/webrtc/rtp_munger.ex 78.57% <0.00%> (-4.45%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb53b63...0f833a4. Read the comment docs.

daniel-jodlos commented 1 year ago

Indeed. Not sure why this was still open after all this time