search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
141 stars 13 forks source link

Limit probing attempts #242

Closed daniel-jodlos closed 1 year ago

daniel-jodlos commented 1 year ago

The aim of this Pull Request is to introduce the most basic way of limiting probing attempts in the :increase_estimation state. This state is now time-limited to 20s. If we don't reach the target during the time window, we won't be triggering another probing attempt unless a full 60 seconds passes or we intend to reach a level lower than achieved in the last attempt.

codecov[bot] commented 1 year ago

Codecov Report

Merging #242 (911e45a) into master (b3aaca2) will increase coverage by 0.14%. The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
+ Coverage   56.96%   57.10%   +0.14%     
==========================================
  Files          35       35              
  Lines        1615     1632      +17     
==========================================
+ Hits          920      932      +12     
- Misses        695      700       +5
Impacted Files Coverage Δ
...ngine/endpoints/webrtc/rtp_connection_allocator.ex 80.00% <71.42%> (-0.93%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3aaca2...911e45a. Read the comment docs.

daniel-jodlos commented 1 year ago

@mickel8 This PR currently has some GCC estimation related issues. Perhaps we should wait for the fix to the estimation in the HOLD state?