search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
141 stars 13 forks source link

Refactor hls tests (remove sleep()) #245

Closed Karolk99 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1620023). Click here to learn what that means. The diff coverage is 94.11%.

@@            Coverage Diff            @@
##             master     #245   +/-   ##
=========================================
  Coverage          ?   57.67%           
=========================================
  Files             ?       38           
  Lines             ?     1786           
  Branches          ?        0           
=========================================
  Hits              ?     1030           
  Misses            ?      756           
  Partials          ?        0
Impacted Files Coverage Δ
lib/membrane_rtc_engine/engine.ex 74.28% <ø> (ø)
..._rtc_engine/endpoints/hls/stream_format_updater.ex 86.66% <50.00%> (ø)
lib/membrane_rtc_engine/endpoints/hls_endpoint.ex 77.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1620023...d823a31. Read the comment docs.

Karolk99 commented 1 year ago

I assume that changes in fixtures are expected?

Yes, besides waiting for a message instead of Process.sleep() I also fixed one problem with propagating end_of_stream in the HLS pipeline that's why fixtures look different. I also checked those files with the use of ffplay.