search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
141 stars 13 forks source link

Custom Endpoint support removed in v0.14.0 #284

Closed Naillik1 closed 1 year ago

Naillik1 commented 1 year ago

Hi, I've encountered an issue when upgrading my application from 0.13.0 to 0.14.0.

My application defines its own endpoints for some custom media processing work, and it appears that support for custom endpoints has been entirely removed from v0.14.0 with no mention in the upgrade guide -- endpoints now appear to be restricted to those defined by membrane_rtc_engine (WebRTC, HLS, and RTMP)

The problem seems to arise from the function Membrane.RTC.Engine.Endpoint.WebRTC.MediaEvent.to_type_string/1, defined here.

Was this an intentional decision? Or is this a bug? The decision to use membrane_rtc_engine at our company was driven by the promise of being able to use the wider membrane ecosystem for custom media processing, and this change seems to completely remove that capability.

Any assistance or workarounds would be much appreciated.

mickel8 commented 1 year ago

Hi @Naillik1! Thanks for spotting this! That's of course a bug :thinking:

mickel8 commented 1 year ago

@Naillik1 could you please try branch from this PR? https://github.com/jellyfish-dev/membrane_rtc_engine/pull/285

sgfn commented 1 year ago

Hi @Naillik1, the fix has been merged and released (v0.14.1). Should you encounter any further problems when using the new version, feel free to reopen this issue. Thanks!

Naillik1 commented 1 year ago

Hi @Naillik1, the fix has been merged and released (v0.14.1). Should you encounter any further problems when using the new version, feel free to reopen this issue. Thanks!

This does the trick -- thanks for the fix!