fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

Cleanup RTC Engine deps. Move metrics to the WebRTC Endpoint #306

Closed mickel8 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #306 (4fbba6a) into master (1286dc9) will increase coverage by 0.10%. The diff coverage is 14.81%.

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   51.47%   51.58%   +0.10%     
==========================================
  Files          36       36              
  Lines        1927     1925       -2     
==========================================
+ Hits          992      993       +1     
+ Misses        935      932       -3     
Files Changed Coverage Δ
...brane_rtc_engine/lib/membrane_rtc_engine/engine.ex 74.47% <ø> (+0.20%) :arrow_up:
...mbrane_rtc_engine/lib/membrane_rtc_engine/utils.ex 0.00% <ø> (ø)
...ane_rtc_engine_webrtc/lib/webrtc/track_receiver.ex 0.00% <0.00%> (ø)
membrane_rtc_engine_webrtc/lib/webrtc_endpoint.ex 0.00% <0.00%> (ø)
membrane_rtc_engine_webrtc/lib/metrics.ex 10.52% <10.52%> (ø)
...brane_rtc_engine_webrtc/lib/webrtc/track_sender.ex 74.76% <100.00%> (+0.93%) :arrow_up:

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1286dc9...4fbba6a. Read the comment docs.

mickel8 commented 1 year ago

Ehh sorry, but why the compiler is not complaining :thinking:

sgfn commented 1 year ago

Ehh sorry, but why the compiler is not complaining 🤔

Probably because membrane_rtp_plugin depends on membrane_telemetry_metrics, so the dep is included anyway 😄

mickel8 commented 1 year ago

Probably because membrane_rtp_plugin depends on membrane_telemetry_metrics, so the dep is included anyway smile

Good point!