search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

Fix `endpoint_id` missing in WebRTC endpoint telemetry label. Release WebRTC 0.2.1 #315

Closed sgfn closed 1 year ago

sgfn commented 1 year ago

This was caused by changes from https://github.com/jellyfish-dev/membrane_rtc_engine/pull/306, the endpoint_id field used to be appended to the telemetry label when adding the endpoint in the engine

Bug caught by Jellyfish tests

codecov[bot] commented 1 year ago

Codecov Report

Merging #315 (89a1bca) into master (0992ceb) will decrease coverage by 0.03%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
- Coverage   52.71%   52.68%   -0.03%     
==========================================
  Files          38       38              
  Lines        1973     1974       +1     
==========================================
  Hits         1040     1040              
- Misses        933      934       +1
Files Changed Coverage Δ
webrtc/lib/webrtc_endpoint.ex 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0992ceb...89a1bca. Read the comment docs.