search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

[RTC-398] file endpoint track config #329

Closed roznawsk closed 9 months ago

roznawsk commented 9 months ago

Replaced track option in File endpoint with track_config. This removes the need to know the endpoint_id when defining the track, which the File endpoint will publish. Now the endpoint_id is assigned to the track after the Endpoint starts.

codecov[bot] commented 9 months ago

Codecov Report

Merging #329 (bd8397f) into master (ec9aa2d) will increase coverage by 0.24%. The diff coverage is 92.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #329 +/- ## ========================================== + Coverage 53.85% 54.10% +0.24% ========================================== Files 41 41 Lines 2061 2072 +11 ========================================== + Hits 1110 1121 +11 Misses 951 951 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [file/test/support/file\_sink\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZmlsZS90ZXN0L3N1cHBvcnQvZmlsZV9zaW5rX2VuZHBvaW50LmV4) | `73.07% <ø> (ø)` | | | [file/lib/file\_source\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZmlsZS9saWIvZmlsZV9zb3VyY2VfZW5kcG9pbnQuZXg=) | `90.90% <92.30%> (+3.03%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/329?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/329?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [ec9aa2d...bd8397f](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/329?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).