search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
141 stars 13 forks source link

Rename functions to be compliant with elixir style guide #349

Closed Karolk99 closed 8 months ago

Karolk99 commented 9 months ago

I'm not sure if we want to rename those functions to be compliant with the newest credo version. There are a lot of variables in code named in is_<name> manner. Also functions from other repositories for example RTP have functions like is_keyframe.

codecov[bot] commented 9 months ago

Codecov Report

Merging #349 (67f9008) into master (164b5dc) will increase coverage by 0.02%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #349 +/- ## ========================================== + Coverage 53.04% 53.07% +0.02% ========================================== Files 53 53 Lines 2411 2410 -1 ========================================== Hits 1279 1279 + Misses 1132 1131 -1 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [engine/lib/membrane\_rtc\_engine/track.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZW5naW5lL2xpYi9tZW1icmFuZV9ydGNfZW5naW5lL3RyYWNrLmV4) | `37.50% <ø> (+4.16%)` | :arrow_up: | | [webrtc/lib/webrtc/rtp\_connection\_allocator.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-d2VicnRjL2xpYi93ZWJydGMvcnRwX2Nvbm5lY3Rpb25fYWxsb2NhdG9yLmV4) | `79.76% <100.00%> (ø)` | | | [webrtc/lib/webrtc/track\_sender.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-d2VicnRjL2xpYi93ZWJydGMvdHJhY2tfc2VuZGVyLmV4) | `73.83% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/349?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/349?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [164b5dc...67f9008](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/349?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).