fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
141 stars 13 forks source link

RTC 445 - Engine shouldn't raise when requesting incorrect simulcast variant #351

Closed Rados13 closed 9 months ago

codecov[bot] commented 9 months ago

Codecov Report

Merging #351 (c282679) into master (0e054fb) will decrease coverage by 0.48%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #351 +/- ## ========================================== - Coverage 53.52% 53.05% -0.48% ========================================== Files 53 53 Lines 2410 2407 -3 ========================================== - Hits 1290 1277 -13 - Misses 1120 1130 +10 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [engine/lib/membrane\_rtc\_engine/engine.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZW5naW5lL2xpYi9tZW1icmFuZV9ydGNfZW5naW5lL2VuZ2luZS5leA==) | `80.37% <100.00%> (-0.38%)` | :arrow_down: | | [engine/lib/membrane\_rtc\_engine/exception.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZW5naW5lL2xpYi9tZW1icmFuZV9ydGNfZW5naW5lL2V4Y2VwdGlvbi5leA==) | `56.25% <ø> (-10.42%)` | :arrow_down: | | [engine/lib/membrane\_rtc\_engine/tees/tee.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZW5naW5lL2xpYi9tZW1icmFuZV9ydGNfZW5naW5lL3RlZXMvdGVlLmV4) | `89.15% <100.00%> (+1.20%)` | :arrow_up: | | [engine/test/support/fake\_source\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZW5naW5lL3Rlc3Qvc3VwcG9ydC9mYWtlX3NvdXJjZV9lbmRwb2ludC5leA==) | `75.00% <100.00%> (-10.72%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/351/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/351?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/351?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [0e054fb...c282679](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/351?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).