search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

Fix sender not sending eos until keyframe #357

Closed roznawsk closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

Merging #357 (6fe75aa) into master (dff4289) will decrease coverage by 0.05%. The diff coverage is 28.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #357 +/- ## ========================================== - Coverage 53.39% 53.35% -0.05% ========================================== Files 53 53 Lines 2457 2459 +2 ========================================== Hits 1312 1312 - Misses 1145 1147 +2 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [engine/test/support/fake\_source\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZW5naW5lL3Rlc3Qvc3VwcG9ydC9mYWtlX3NvdXJjZV9lbmRwb2ludC5leA==) | `68.75% <ø> (ø)` | | | [file/lib/file\_source\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZmlsZS9saWIvZmlsZV9zb3VyY2VfZW5kcG9pbnQuZXg=) | `85.71% <66.66%> (+0.23%)` | :arrow_up: | | [...ine/lib/membrane\_rtc\_engine/static\_track\_sender.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZW5naW5lL2xpYi9tZW1icmFuZV9ydGNfZW5naW5lL3N0YXRpY190cmFja19zZW5kZXIuZXg=) | `0.00% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/357/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/357?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/357?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [dff4289...6fe75aa](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/357?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).