fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

[RTC-455] Fix multiple RCs when removing tracks quickly #358

Closed sgfn closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

Merging #358 (c899362) into master (07341b4) will decrease coverage by 0.02%. The diff coverage is 56.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #358 +/- ## ========================================== - Coverage 53.45% 53.43% -0.02% ========================================== Files 53 53 Lines 2443 2457 +14 ========================================== + Hits 1306 1313 +7 - Misses 1137 1144 +7 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [engine/lib/membrane\_rtc\_engine/engine.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZW5naW5lL2xpYi9tZW1icmFuZV9ydGNfZW5naW5lL2VuZ2luZS5leA==) | `83.49% <92.00%> (+0.22%)` | :arrow_up: | | [webrtc/lib/webrtc\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-d2VicnRjL2xpYi93ZWJydGNfZW5kcG9pbnQuZXg=) | `0.00% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/358/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/358?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/358?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [07341b4...c899362](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/358?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).