search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

[RTC-476] Add crash groups, fix adding nonexistent tracks to state, fix READMEs #366

Closed sgfn closed 5 months ago

codecov[bot] commented 6 months ago

Codecov Report

Merging #366 (a30f511) into master (36d1c4f) will decrease coverage by 0.08%. The diff coverage is 10.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #366 +/- ## ========================================== - Coverage 52.80% 52.73% -0.08% ========================================== Files 58 59 +1 Lines 2534 2545 +11 ========================================== + Hits 1338 1342 +4 - Misses 1196 1203 +7 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [engine/lib/membrane\_rtc\_engine/engine.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZW5naW5lL2xpYi9tZW1icmFuZV9ydGNfZW5naW5lL2VuZ2luZS5leA==) | `83.49% <ø> (ø)` | | | [...on\_test/test/support/crashing\_recording\_storage.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-aW50ZWdyYXRpb25fdGVzdC90ZXN0L3N1cHBvcnQvY3Jhc2hpbmdfcmVjb3JkaW5nX3N0b3JhZ2UuZXg=) | `100.00% <100.00%> (ø)` | | | [recording/lib/recording\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9yZWNvcmRpbmdfZW5kcG9pbnQuZXg=) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/366/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/366?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/366?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [36d1c4f...a30f511](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/366?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).
sgfn commented 6 months ago

We should also add a test for the track crash group. My idea is to use get_child_pid to crash one of the endpoints in the track's pipeline.

Sounds reasonable, I'll give it a go