search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

[RTC-478] Add endpoint crash reason #368

Closed roznawsk closed 5 months ago

roznawsk commented 6 months ago

ref: https://github.com/jellyfish-dev/protos/pull/16 https://github.com/jellyfish-dev/jellyfish/pull/161

codecov[bot] commented 6 months ago

Codecov Report

Merging #368 (aff9fa0) into master (c652aa8) will increase coverage by 0.09%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #368 +/- ## ========================================== + Coverage 53.35% 53.45% +0.09% ========================================== Files 61 61 Lines 2592 2593 +1 ========================================== + Hits 1383 1386 +3 + Misses 1209 1207 -2 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [engine/lib/membrane\_rtc\_engine/engine.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZW5naW5lL2xpYi9tZW1icmFuZV9ydGNfZW5naW5lL2VuZ2luZS5leA==) | `83.22% <100.00%> (-0.28%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/368/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/368?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/368?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [c652aa8...aff9fa0](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/368?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).
roznawsk commented 5 months ago

Does this require any changes in our WS API description or protobufs? @mickel8

Yup, changes in protobuf are referenced in the description